feat(i18n): add Astro.currentLocale
#9101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c56b5d9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
natemoo-re
approved these changes
Nov 14, 2023
sarah11918
reviewed
Nov 15, 2023
sarah11918
reviewed
Nov 15, 2023
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'astro': patch | |||
There was a problem hiding this comment.
Also checking that this is a patch, so only waiting for the feature to merge but not for the next minor release? If so, please help me remember when the corresponding docs PR should merge, since it's not on the normal release schedule! 😄 withastro/docs#5410
There was a problem hiding this comment.
Once the PR is merged, this new thing will go out in the next release (regardless of its entity).
remember when the corresponding docs PR should merge
Ideally, we should merge it before the next release. Although we don't have a schedule for that, I think it's also okay if the docs PR is released 1/2 day after.
ematipico
force-pushed
the
feat/current-locale
branch
from
d477c27 to
fecba55
Compare
ematipico
force-pushed
the
feat/current-locale
branch
from
fecba55 to
c56b5d9
Compare
bluwy
approved these changes
Nov 16, 2023
Merged
peng
added a commit
to peng/astro
that referenced
this pull request
Nov 17, 2023
* main: feat(i18n): add `Astro.currentLocale` (withastro#9101) [ci] release (withastro#9107) Add compatibility with cloudflare node (withastro#8925) [ci] format Cancel response stream when connection closes (withastro#9071) [ci] format feat(i18n): apply specific routing logic only to pages (withastro#9091) feat(dev-overlay): Hide plugins into a separate menu when there's too many enabled (withastro#9102) [ci] format Support Svelte 5 (experimental) (withastro#9098) [ci] release (withastro#9078) [ci] format Refactor shikiji syntax highlighting code (withastro#9083) [ci] format fix: Query params trigger the trailingSlash error in preview mode (withastro#9045) fix(assets): bundling regression for specific config on non-Node runtimes (withastro#9087)
FredKSchott
pushed a commit
that referenced
this pull request
Nov 18, 2023
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Jul 29, 2024
* See withastro/astro#4986 for `site`, `generator`, `url`, `clientAddress`, `props` and `redirect` * See withastro/astro#6721 for `locals` * See withastro/astro#9021 for `preferredLocale` and `preferredLocaleList` * See withastro/astro#9101 for `currentLocale`
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Jul 29, 2024
* See withastro/astro#4986 for `site`, `generator`, `url`, `clientAddress`, `props` and `redirect` * See withastro/astro#6721 for `locals` * See withastro/astro#9021 for `preferredLocale` and `preferredLocaleList` * See withastro/astro#9101 for `currentLocale`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RFC change: withastro/roadmap@f934880
This PR adds a new
Astro.currentLocale, which is computed fromRequest#url,i18n.locales,i18n.routingStrategyandi18n.defaultLocaleIf the routing strategy is
prefix-other-locales, for any URL that doesn't contain a locale, we return thedefaultLocale.This PR adds a bunch of data that we pass down the rendering of the page/endpoint, very similar to the same work I did when implementing
preferredLocale.Closes PLT-1207
Testing
I added new test cases that should cover new use cases.
Docs
withastro/docs#5410
/cc @withastro/maintainers-docs for feedback!