fix(redirects): handle non-verbatim targets #9089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5689425 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
lilnasy
commented
Nov 13, 2023
| @@ -20,6 +20,7 @@ export function redirectRouteGenerate(redirectRoute: RouteData, data: Params): s | |||
| if (typeof routeData !== 'undefined') { | |||
| return routeData?.generate(data) || routeData?.pathname || '/'; | |||
| } else if (typeof route === 'string') { | |||
| console.log({ data, pattern: route}); | |||
1 task
|
@lilnasy what's the status of this PR? Did you encounter some blocker? |
|
It's just here to explain the code path that goes wrong. |
github-actions
bot
added
the
pr: docs
ematipico
approved these changes
Dec 15, 2023
Comment on lines
26
to
27
| for (const param in data) { | ||
| const paramValue = data[param]! |
There was a problem hiding this comment.
nit: I don't like very much the use of for..in, we should use for..of
There was a problem hiding this comment.
const dataAsArray =Object.entries(data);
if (dataAsArray.length > 0) {
for (const t of dataAsArray) {}
}There was a problem hiding this comment.
oh didnt see this, implemented using object.keys
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
Does not affect usage.