Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Query params trigger the trailingSlash error in preview mode #9045

Merged
merged 6 commits into from
Nov 14, 2023
Merged

fix: Query params trigger the trailingSlash error in preview mode #9045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fad027f
Update vite-plugin-astro-preview.ts
Nov 10, 2023
e841956
Create tidy-peas-accept.md
Nov 10, 2023
46ff140
Merge branch 'main' into patch-3
Nov 11, 2023
f640c31
const instead of let
Nov 11, 2023
e42dde6
Merge branch 'main' into patch-3
Nov 14, 2023
f2b3a4a
Update .changeset/tidy-peas-accept.md
bluwy Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-peas-accept.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes preview server `trailingSlash` handling for request URLs with query strings
3 changes: 2 additions & 1 deletion packages/astro/src/core/preview/vite-plugin-astro-preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export function vitePluginAstroPreview(settings: AstroSettings): Plugin {
return;
}

const pathname = stripBase(req.url!, base);
const strippedPathname = stripBase(req.url!, base);
const pathname = new URL(strippedPathname, 'https://a.b').pathname
rishi-raj-jain marked this conversation as resolved.
Show resolved Hide resolved
const isRoot = pathname === '/';

// Validate trailingSlash
Expand Down
Loading