feat(overlay): Add click to go to editor for audits #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3962a6e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
⚖️ Bundle Size CheckLatest commit: 3962a6e
|
Princesseuh
commented
Nov 8, 2023
| @@ -24,7 +24,7 @@ const first = defineMiddleware(async (context, next) => { | |||
| const response = await next(); | |||
| const newResponse = response.clone(); | |||
| const /** @type {string} */ html = await newResponse.text(); | |||
| const newhtml = html.replace('<h1>testing</h1>', '<h1>it works</h1>'); | |||
| const newhtml = html.replace('testing', 'it works'); | |||
There was a problem hiding this comment.
So, this is a bit awkward. But since we now add attributes, those kind of naive replacements don't work in dev.
In my humble, informed, opinion, you shouldn't rely on string replaces like this anyway, because whitespaces, minification etc etc could ruin it anyway. Typically, I'd recommend people to use a real tool for this, like https://github.com/cloudflare/lol-html
matthewp
approved these changes
Nov 8, 2023
bluwy
reviewed
Nov 8, 2023
Co-authored-by: Bjorn Lu <[email protected]>
Princesseuh
commented
Nov 8, 2023
bluwy
approved these changes
Nov 8, 2023
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
* feat(overlay): Add click to go to editor for audits * chore: changeset * chore: update compiler dep * fix: tests * Update packages/astro/src/core/compile/compile.ts Co-authored-by: Bjorn Lu <[email protected]> * Update packages/astro/src/core/compile/compile.ts --------- Co-authored-by: Bjorn Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Much like you can go to the editor for xray, now you can for audits.
Testing
Will be tested in a separate PR
Docs
N/A