-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assets): Delete original assets unused outside of the optimization pipeline #8954
Conversation
🦋 Changeset detectedLatest commit: 023be5d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very nice use of Proxy
. You could get rid of the // @ts-expect-error
but it's not a huge deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just turned this into something that could go in the blog post!
Co-authored-by: Sarah Rainsberger <[email protected]>
…on pipeline (#8954) Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
What the title says. On the technical level, this works by making images Proxies, whenever any property of an image is referred to directly we add the image to a list of images to not delete.
Fix #8143
Testing
Tests should pass!
Docs
N/A, we didn't document that they stayed there before.