Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-astro): TypeScript installation failure with yarn #8939

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix(create-astro): TypeScript installation failure with yarn #8939

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
132563d
fix(create-astro): TypeScript installation failure with yarn
wktk Oct 28, 2023
2201e28
Update .changeset/young-avocados-wink.md
wktk Oct 28, 2023
b97904d
Merge branch 'main' into fix-creating-with-ts-yarn
Princesseuh Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-avocados-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': patch
---

Fix TypeScript installation issue with yarn
wktk marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions packages/create-astro/src/actions/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ const FILES_TO_UPDATE = {
try {
// add required dependencies for astro check
if (options.ctx.install)
await shell(options.ctx.packageManager, ['install', '@astrojs/check', 'typescript'], {
await shell(options.ctx.packageManager, ['add', '@astrojs/check', 'typescript'], {
cwd: path.dirname(file),
stdio: 'ignore',
});

// inject addtional command to build script
// inject additional command to build script
const data = await readFile(file, { encoding: 'utf-8' });
const indent = /(^\s+)/m.exec(data)?.[1] ?? '\t';
const parsedPackageJson = JSON.parse(data);
Expand Down
Loading