Recommend the VS Code MDX extension #8897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old recommendation was to mark MDX files as markdown. MDX supports various constructs that markdown doesn’t, so that leads to bad syntax highlighting.
🦋 Changeset detectedLatest commit: 24a60ea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
natemoo-re
approved these changes
Oct 23, 2023
github-actions
bot
removed
the
pr: docs
bluwy
approved these changes
Oct 24, 2023
delucis
reviewed
Oct 24, 2023
Co-authored-by: Chris Swithinbank <[email protected]>
delucis
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks @remcohaszing for the update!
If you’re interested in a follow-up, I guess we could also include unifiedjs.vscode-mdx in the recommended extensions in our blog starter project, which uses MDX:
github-actions
bot
added
the
pr: docs
|
I'm going to merge this since we're about to do a release, but yeah I like @delucis' suggestion as well! If you'd like to open a PR with that change, please do! |
Merged
natemoo-re
added a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Chris Swithinbank <[email protected]> Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This replaces the the old recommendation to mark MDX files as markdown with the recommendation to use the official MDX extension. MDX supports various constructs that markdown doesn’t, so that leads to bad syntax highlighting.
Testing
This is a documentation-only change.
Docs
This is a documentation-only change.