Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Vercel serverless generate static redirect pages #8896

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Prevent Vercel serverless generate static redirect pages #8896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-steaks-confess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/vercel': patch
---

Prevents the Vercel serverless adapter from generating static redirect pages in hybrid mode
1 change: 1 addition & 0 deletions packages/integrations/vercel/src/serverless/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export default function vercelServerless({
serverEntry: 'entry.mjs',
client: new URL('./static/', outDir),
server: new URL('./dist/', config.root),
redirects: false,
},
vite: {
...getSpeedInsightsViteConfig(speedInsights?.enabled || analytics),
Expand Down
7 changes: 7 additions & 0 deletions packages/integrations/vercel/test/fixtures/redirects-serverless/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { defineConfig } from 'astro/config';
import vercel from '@astrojs/vercel/serverless';

export default defineConfig({
output: 'hybrid',
adapter: vercel(),
});
9 changes: 9 additions & 0 deletions packages/integrations/vercel/test/fixtures/redirects-serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"name": "@test/astro-vercel-redirects-serverless",
"version": "0.0.0",
"private": true,
"dependencies": {
"@astrojs/vercel": "workspace:*",
"astro": "workspace:*"
}
}
8 changes: 8 additions & 0 deletions packages/integrations/vercel/test/fixtures/redirects-serverless/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<html>
<head>
<title>Testing</title>
</head>
<body>
<h1>Testing</h1>
</body>
</html>
Empty file added packages/integrations/vercel/test/fixtures/redirects-serverless/src/pages/subpage.astro
View file
Open in desktop
Empty file.
28 changes: 28 additions & 0 deletions packages/integrations/vercel/test/redirects-serverless.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { expect } from 'chai';
import { loadFixture } from './test-utils.js';

describe('Redirects Serverless', () => {
/** @type {import('astro/test/test-utils.js').Fixture} */
let fixture;

before(async () => {
fixture = await loadFixture({
root: './fixtures/redirects-serverless/',
redirects: {
'/one': '/',
'/other': '/subpage',
},
});
await fixture.build();
});

it('does not create .html files', async () => {
let hasErrored = false;
try {
await fixture.readFile('../.vercel/output/static/other/index.html');
} catch {
hasErrored = true;
}
expect(hasErrored).to.equal(true, 'this file should not exist');
});
});
9 changes: 9 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading