Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Rollup 4 hash change #8875

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Handle Rollup 4 hash change #8875

merged 1 commit into from
Oct 20, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 20, 2023

Changes

Handle Vite 5 and Rollup 4 where emitFile now returns base64url hash with - replaced as $, and file name [hash] replaced with base64url hash too.

The former hash can be matched with [\w$]{8} while the latter [\w-]{8}.

Rollup 4 migration guide: https://rollupjs.org/migration/#general-changes

Otherwise, an obvious change is that Rollup now uses url-safe base64 hashes in file names instead of the older base16 hashes. This provides more hash safety but means that hash length is now limited to at most 22 characters for technical reasons.

NOTE: These new hash regex covers a wider range of characters, so it should be backwards compatible too.

Testing

Ran tests locally.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

⚠️ No Changeset found

Latest commit: 66da7ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 20, 2023
@bluwy bluwy merged commit c36d80a into main Oct 20, 2023
13 checks passed
@bluwy bluwy deleted the handle-vite-5 branch October 20, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants