Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a label for PRs that include documentation changes #8865

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Add a documentation pr label to Pull Requests that change the files that affects the docs site.
  • This is intended to be used instead of the review assignee, for a better workflow for the docs team.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: 4ef6a85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hopefully this will be a smoother workflow.

.github/labeler.yml Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Looks great! Quick reminder that this will not auto-apply to any changesets. So, if any of those require docs' attention, then the label might need to be manually added if there isn't already a README etc.

Thank you @matthewp !

@natemoo-re
Copy link
Member

natemoo-re commented Oct 18, 2023

Looks great! Quick reminder that this will not auto-apply to any changesets. So, if any of those require docs' attention, then the label might need to be manually added if there isn't already a README etc.

We could definitely add .changeset/*.md to the configuration as well! Would that be wise?

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Oct 18, 2023

Quick reminder that this will not auto-apply to any changesets.

Aren't those parts also glob compatible. I mean could we add just the .changeset/**/*.md?

Update: Screw it.. @natemoo-re was faster 🚀

@sarah11918
Copy link
Member

It's only wise if you want me adding s and es to all your changesets...

@alexanderniebuhr
Copy link
Member

I'm in favor of that. For contributors who do more than one PR, it will take 1-2 PRs, and they will already adapt the habit 🚀

@matthewp
Copy link
Contributor Author

Will add that too.

@matthewp matthewp merged commit 0d4922d into main Oct 18, 2023
13 checks passed
@matthewp matthewp deleted the documentation-labels branch October 18, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants