Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(astro): terminal HMR path (close #8831) #8863

Merged
merged 8 commits into from
Oct 20, 2023
Merged

fix(astro): terminal HMR path (close #8831) #8863

merged 8 commits into from
Oct 20, 2023

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Oct 18, 2023 •
edited
Loading

Changes

Testing

Tested by pointing the @example/basics astro version to the local one (workspace:*), only on Windows.

Docs

No change required

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a3de19c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 18, 2023
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Oct 18, 2023
@sarah11918 sarah11918 removed the pr: docs A PR that includes documentation for review label Oct 19, 2023
@florian-lefebvre @sarah11918
Update .changeset/two-lamps-tell.md
213e1c4 
Co-authored-by: Sarah Rainsberger <[email protected]>
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Oct 19, 2023
lilnasy
lilnasy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

The big codebase and the tooling around it can be intimidating, but you breezed through it 💪

@ematipico ematipico merged commit 326e178 into withastro:main Oct 20, 2023
@astrobot-houston astrobot-houston mentioned this pull request Oct 20, 2023
Merged
@florian-lefebvre florian-lefebvre deleted the fix/root-cli-path branch October 20, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@lilnasy lilnasy lilnasy approved these changes

@bluwy bluwy bluwy approved these changes

@ematipico ematipico ematipico approved these changes

@natemoo-re natemoo-re Awaiting requested review from natemoo-re

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@florian-lefebvre @ematipico @sarah11918 @natemoo-re @bluwy @lilnasy