Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port https://github.com/withastro/docs/pull/4980 #8799

Merged
merged 1 commit into from
Oct 11, 2023
Merged

port https://github.com/withastro/docs/pull/4980 #8799

merged 1 commit into from
Oct 11, 2023

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr requested a review from a team as a code owner October 10, 2023 17:43
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: c11e11d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 10, 2023
sarah11918
sarah11918 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Sorry docs didn't catch this on our end that the change should have been made here instead!

Thanks for snagging this, @alexanderniebuhr ! 🙌

@alexanderniebuhr alexanderniebuhr merged commit 3f231ce into main Oct 11, 2023
2 checks passed
@alexanderniebuhr alexanderniebuhr deleted the alexanderniebuhr-patch-1 branch October 11, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderniebuhr @sarah11918