fix(assets): add the missing await
to getHTMLAttributes
#8773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request adds the missing
await
to properly use values returned bygetHTMLAttribute
in image services. It fixes an issue where HTML attributes do not render if getHTMLAttributes in an image service returns a Promise.Minimum repro for this issue: StackBlitz (You can see that the custom HTML attributes are not rendered in the HTML if
getHTMLAttribute
returns a Promise instead a plain object)Definition for
getHTMLAttribute
:astro/packages/astro/src/assets/services/service.ts
Lines 41 to 50 in 30de324
Testing
No tests were added as this is a one-line fix. It should have no impact if
getHTMLAttributes
returns a non-Promise.Docs
No docs were needed as this fix does not change the expected behavior.