Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown rehype plugin example #8733

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix markdown rehype plugin example #8733

merged 2 commits into from
Oct 4, 2023

Conversation

Insidiae
Copy link
Contributor

@Insidiae Insidiae commented Oct 3, 2023

Changes

Testing

Tested manually to verify the sample code shows the updated plugin:

image

Docs

I made this PR as directed from the issue from the Astro Docs repo. I simply used the same example plugin already used in the Markdown & MDX docs page.

/cc @withastro/maintainers-docs for feedback!

@Insidiae Insidiae requested a review from a team as a code owner October 3, 2023 07:31
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: 65564de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 3, 2023
@bluwy
Copy link
Member

bluwy commented Oct 3, 2023

Before merging this, a small question to @withastro/maintainers-docs if we should link this PR to close withastro/docs#4549, or would that be separately handled?

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bluwy bluwy merged commit 71618f4 into withastro:main Oct 4, 2023
16 of 17 checks passed
martrapp pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong instructions for rehype plugins
5 participants