Fix CSS styles on windows #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cde8743 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
alexanderniebuhr
approved these changes
Oct 2, 2023
alexanderniebuhr
approved these changes
Oct 2, 2023
|
I can reproduce the issue and confirm it's fixed with these changes. |
natemoo-re
approved these changes
Oct 2, 2023
matthewp
approved these changes
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #8720
The main fix is for this specific line:
astro/packages/astro/src/vite-plugin-astro-server/route.ts
Line 314 in 22fae52
I changed the
urlto anid, thinking it doesn't affect it, but I missed that it did! This PR makesurlan actual URL. But I also need theidfordata-vite-dev-idbelow, so I refactoredgetStylesForURLto achieve that. The rest of the changes are the refactors for it.Testing
Don't have a Windows machine to test this, but I spotted this is the main unintended change from #8706
Docs
n/a. bug fix.