Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): broken link in docs #8709

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Conversation

alexanderniebuhr
Copy link
Member

/cc @withastro/maintainers-docs for feedback!

@alexanderniebuhr alexanderniebuhr requested a review from a team as a code owner September 29, 2023 20:12
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

⚠️ No Changeset found

Latest commit: 334f7ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 29, 2023
@yanthomasdev
Copy link
Member

Thanks @alexanderniebuhr, nice catch! Since we're already on the "fix links" topic, our CI also found out we have a bad link description in regards to a11y, could you add the following change to line as well 172?:

Add `wasmModuleImports: true` to `astro.config.mjs` to enable this functionality in both the Cloudflare build and the Astro dev server. Read more about [using Wasm modules](#use-wasm-modules)

With both done our docs integrations CI should be perfectly unblocked 🙌

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out to me!

@alexanderniebuhr alexanderniebuhr merged commit 0b22bb9 into main Sep 30, 2023
@alexanderniebuhr alexanderniebuhr deleted the alexanderniebuhr-patch-1 branch September 30, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants