Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in error deprecation message #8708

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

Genteure
Copy link
Contributor

Changes

Changed omitted to given.

"Omitted" seems like a typo for "emitted". Sarah suggested "given" on discord, and I like "given" better too!

Testing

N/A, no code changes in this PR.

Docs

N/A, simple typo fix.

@Genteure Genteure requested a review from a team as a code owner September 29, 2023 12:35
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

⚠️ No Changeset found

Latest commit: df14fcb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Genteure ! Not only fixed, but better! 🙌

@alexanderniebuhr alexanderniebuhr merged commit f9477aa into withastro:main Oct 2, 2023
16 checks passed
martrapp pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants