Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin CI Node version to 18.17.1 #8693

Merged
merged 4 commits into from
Sep 28, 2023
Merged

chore(ci): pin CI Node version to 18.17.1 #8693

merged 4 commits into from
Sep 28, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Sep 28, 2023

Changes

  • CI - Node 18.18 breaks playwright (not just playwright) on windows.

Testing

  • Does not affect behavior.

Docs

  • Does not affect usage.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

⚠️ No Changeset found

Latest commit: 0b24706

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Sep 28, 2023
@matthewp
Copy link
Contributor

In my PR: #8684 the Test CI one is failing too. Any reason not to do them both until this issue is resolved upstream?

@lilnasy
Copy link
Contributor Author

lilnasy commented Sep 28, 2023

It was neccessary for the "test" job as well, but that didn't fail the checks because branches in the withastro org use cache, and the "test" job was skipped.

@lilnasy lilnasy changed the title chore(ci): pin E2E Node version to 18.17.1 chore(ci): pin CI Node version to 18.17.1 Sep 28, 2023
@lilnasy lilnasy merged commit 23e7b25 into main Sep 28, 2023
@lilnasy lilnasy deleted the e2e-fix branch September 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants