Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print image path for NoImageMetadata #8666

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

nolanlawson
Copy link
Contributor

Fixes #8665

Changes

  • Fixes the error message so that it includes the image path

Testing

I did not add a test or repro, because the bug and fix seem fairly clear to me from the code.

Docs

I don't think docs need to be updated.

@nolanlawson nolanlawson requested a review from a team as a code owner September 26, 2023 01:46
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 43ea266

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 26, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple change, thanks for fixing it!

@bluwy bluwy merged commit 9fe4b95 into withastro:main Sep 26, 2023
12 of 13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoImageMetadata does not log the image path
2 participants