-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Head propagation graph walking on new pages #8646
Conversation
🦋 Changeset detectedLatest commit: 475600e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
configureServer(_server) { | ||
server = _server; | ||
}, | ||
resolveId(source, importer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're handling the propagation in resolveId
. Could we remove the similar code in the transform
hook entirely? Or do they work differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this... I think we probably could. I don't fully trust the test coverage though. I'd rather leave a TODO and try and remove it later when feeling more brave.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍 Probably worth circle back whenever possible as it touches on perf
Changes
transition:
directives, walking up parents to mark them with metadatain-tree
.in-tree
if needed.Testing
Docs
N/A, bug fix