fix: no deletion of scripts during view transition #8636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 50b7f57 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
Sep 22, 2023
| } else { | ||
| s1.remove(); | ||
| // the old script is in the new document: we mark it as executed to prevent re-execution | ||
| s2.dataset.astroExec = ''; |
There was a problem hiding this comment.
very clever, this also means they will exist on the next page transition, so they won't be removed there either.
matthewp
approved these changes
Sep 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
there were some problems with the deletion of scripts during view transition (to prevent re-execution)
No they are not deleted anymore but simply marked as already executed
Testing
pass existing e2e tests
Docs
bug fix, n/a