Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Improve manual install guide of @astrojs/tailwind integration #8619

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Sep 21, 2023

Changes

Testing

  • It was manually tested

@dreyfus92 dreyfus92 requested a review from a team as a code owner September 21, 2023 17:02
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

⚠️ No Changeset found

Latest commit: bc311c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 21, 2023
@florian-lefebvre
Copy link
Member

I think the base.css is optional because it's already injected by the integration but I'd like someone to confirm

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering this! Looks like the quick install covers the config file step, but isn't documented in the manual install guide.

packages/integrations/tailwind/README.md Outdated Show resolved Hide resolved
packages/integrations/tailwind/README.md Outdated Show resolved Hide resolved
packages/integrations/tailwind/README.md Outdated Show resolved Hide resolved
packages/integrations/tailwind/README.md Outdated Show resolved Hide resolved
@dreyfus92
Copy link
Member Author

Thank you for all your feedback @bluwy and @florian-lefebvre 😁

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great everyone! Thanks for grabbing the issue @dreyfus92 !

I'm approving, but I'm not sure whether we want a changeset here, so I'll leave it to someone else to decide and merge.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants