-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shikiji #8502
Use shikiji #8502
Conversation
🦋 Changeset detectedLatest commit: b491e6b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I wonder if we could move shared code inside the internal-helpers
package.
With respect to docs, I would only expect we need to add docs to the site if:
Outside of these conditions, there's probably not much we would document? We don't tend to explain a lot of inner workings, but rather how to do things. If the user has to act differently, or will notice different behaviour even as the result of changing nothing, these are the two big flags for docs. |
Probably the only visible change is the markup where And |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @bluwy ! Just some very minor changes to the opening line, but I think this is more than helpful for describing the change!
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
Use shikiji instead of shiki. Also added compat code so it should work as before
Testing
Existing tests should pass
Docs
Most docs around shiki should also apply to shikiji, so I don't think we need to update the docs. The ideal case is to also have shikiji's improvements upstreamed to shiki.