Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add leading and trailing slash sanitization for params #8276

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

FredKSchott
Copy link
Member

Changes

image

  • Someone reported an issue where getStaticPaths were silently failing to match expected params (see the error above)
  • This was due to them constructing their own route params, and incorrectly assuming that they needed a trailing slash in the slug in order to match a trailing slash in the URL.
  • Since we handle this for you at the Astro layer, I can't think of a world where / would be expected behavior either leading or trailing in some route param.
  • Therefore, I got nerd sniped into adding some simple route param sanitization

Testing

  • Test added

Docs

  • No docs needed

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: 5d5faa2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 29, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natemoo-re natemoo-re merged commit d3a6f9f into main Aug 31, 2023
@natemoo-re natemoo-re deleted the route-param-sanitization branch August 31, 2023 18:05
@astrobot-houston astrobot-houston mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants