-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vercel adapter default changes #8239
Conversation
🦋 Changeset detectedLatest commit: d69065d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would just tighten up the wording a bit, but LGTM!
Co-authored-by: Sarah Rainsberger <[email protected]>
packages/integrations/vercel/test/fixtures/serverless-prerender/astro.config.mjs
Outdated
Show resolved
Hide resolved
@@ -0,0 +1 @@ | |||
import './throw.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can remove both of these and just update the package.json imports mapping to point both to throw.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 small comment
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Emanuele Stoppa <[email protected]>
Changes
functionPerRoute
default totrue
.Testing
Docs