Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel adapter default changes #8239

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Vercel adapter default changes #8239

merged 9 commits into from
Aug 28, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Makes functionPerRoute default to true.
  • Adds back in stubs for the edge adapter, to error and point people towards using serverless + edge middleware.

Testing

  • Tests should still work

Docs

  • Needs docs review.

@matthewp matthewp requested a review from a team as a code owner August 26, 2023 13:10
@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2023

🦋 Changeset detected

Latest commit: d69065d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 26, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would just tighten up the wording a bit, but LGTM!

.changeset/silly-dolphins-try.md Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
import './throw.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can remove both of these and just update the package.json imports mapping to point both to throw.js

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 small comment

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 28, 2023
.changeset/silly-dolphins-try.md Outdated Show resolved Hide resolved
.changeset/silly-dolphins-try.md Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 52f0837 into main Aug 28, 2023
@matthewp matthewp deleted the vercel-changes branch August 28, 2023 16:10
This was referenced Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants