fix: reinsert attribute to specify direction of ViewTransition #8109
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ae9187 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
Aug 17, 2023
| @@ -233,15 +232,17 @@ const { fallback = 'animate' } = Astro.props as Props; | |||
| location.href = href; | |||
| return; | |||
| } | |||
| document.documentElement.dataset.astroTransition = dir; | |||
There was a problem hiding this comment.
why here and not inside of updateDOM?
There was a problem hiding this comment.
:)
- symmetry: removing the attribute is done a few lines further down in "Navigate". Same level.
- When I removed
doc.documentElement.dataset.astroTransition = dirfromupdateDOM, it was clear that updating the DOM does semantically not depend on a direction. (this was the only usage ofdirin this function)
Thought the code only moved there, because of the dependency on the parseddoc-DOM (doc) - simpler, less parameters for updateDOM
There was a problem hiding this comment.
Ok, trust your judgment here, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astroTransition = diris now set for the current document.The removal of the attribute from the DOM is put on hold for now, since the removal seems to prevent fallback animations.
Plus: fix for an of-by-one bug I introduced in a previous commit that prevented the correct detection of direction ;-)
Testing
Manual tests only
Docs
n/a bug fix