Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerendering corner cases #8070

Merged
merged 15 commits into from
Aug 17, 2023
Merged

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Aug 14, 2023

Changes

Testing

  • Adjusted node/prerender-404 to actually check that it prerendered
  • Added a test that checks styles/scripts are included for indirectly routed 500 pages

Docs

Does not affect usage

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 7c17ee5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 14, 2023
@lilnasy lilnasy force-pushed the prerender-corner-cases branch from f42f28e to a9f985e Compare August 14, 2023 13:59
@lilnasy lilnasy force-pushed the prerender-corner-cases branch 5 times, most recently from 05ffc46 to 2442c6c Compare August 15, 2023 01:39
@lilnasy lilnasy marked this pull request as ready for review August 15, 2023 19:15
@lilnasy
Copy link
Contributor Author

lilnasy commented Aug 15, 2023

Ready for review.

The change did not fix #7973 unfortunately.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much for digging into this!

@ematipico ematipico merged commit 097a8e4 into withastro:main Aug 17, 2023
This was referenced Aug 17, 2023
@lilnasy lilnasy deleted the prerender-corner-cases branch August 22, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerended custom 500 page does not include imported stylesheets
4 participants