Fix missing CSS when 404 server Response redirects to a custom 404 page

[andremralves]

Changes

Closes #7910

The regression was introduced here #7703 because of a typo.

This PR changes the variable used in #createRenderContext back to the correct one: errorRouteData.

The change was simple (but really hard to find) and I also added some tests to prevent this error from happening again.

Testing

One test to check imports in 404 redirections to a custom 404 page using contentCollections.

Docs

n/a

[changeset-bot]

🦋 Changeset detected

Latest commit: 77aae41

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bluwy]

Thanks for fixing this. Besides the merge conflicts, this lgtm

[andremralves]

I will fix the conflicts.

[natemoo-re]

Good catch! I'm guessing the conflicts are coming from #7754 which was merged quite recently. Please check out that PR. It might have fixed this issue already?

[andremralves]

Good catch! I'm guessing the conflicts are coming from #7754 which was merged quite recently. Please check out that PR. It might have fixed this issue already?

I also thought your PR might have fixed the issue, so I made some tests, but the problem was still showing up.

I believe that the line const finalRouteData = routeData ?? errorRouteData; can be the problem, shouldn't we always use errorRouteData to create the render context as const mod will aways use errorRouteData?

In my tests, the problem was being caused because a route other than /404 was being passed to #createRenderContext inside the finalRouteData constant.

I just could reproduce this error using ssr with contentCollections. An example can be found in the tests that I made.

[andremralves]

I made a new commit merging the branches and changing a little bit the behavior of #renderError, I believe the issue is fixed now. But a careful review would be good because the logic was different.

[natemoo-re]

Thanks for the thorough update and adjusting to fix the updated logic! This change makes a lot of sense and looks good to me!

[paulrudy]

Thanks for finding and addressing this!