Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track added links/styles/scripts to prevent duplicates #7843

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • packages/integrations/mdx/test/css-head-mdx.test.js was failing but now should pass.

Docs

N/A, bug fix

@matthewp matthewp requested a review from a team as a code owner July 27, 2023 17:26
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: 20b898a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 27, 2023
@matthewp
Copy link
Contributor Author

Going to merge this since it's a regression. Happy to revert post-release if anyone sees a problem with it!

@matthewp matthewp merged commit 7dbcbc8 into main Jul 27, 2023
@matthewp matthewp deleted the fix-head-buffer branch July 27, 2023 18:42
@astrobot-houston astrobot-houston mentioned this pull request Jul 27, 2023
@bluwy
Copy link
Member

bluwy commented Jul 28, 2023

@matthewp I actually had the fix at #7838. I also noticed the duplicate links but it was fixed in a simpler way. The regression was due to my rendering refactoring.

I think we can revert this and merge my PR instead? 😬

bluwy added a commit that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants