Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Image component to get transitions #7836

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Allow the Image component to get transitions #7836

merged 6 commits into from
Jul 27, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 27, 2023

Changes

  • Upgrades the compiler which now adds the data-astro-transition-scope attribute when using one of the transition directives.
  • Image was already forwarding props to the image.

Testing

  • New test added. This ensures that the Image tag will keep forwarding the prop.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: 537ed93

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 27, 2023
@matthewp matthewp marked this pull request as ready for review July 27, 2023 12:58
@matthewp matthewp merged commit 59b5562 into main Jul 27, 2023
@matthewp matthewp deleted the vt-image branch July 27, 2023 19:08
@astrobot-houston astrobot-houston mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant