fix(assets): Fix endpoint not being injected when an integration would enable experimental.assets
#7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d enable `experimental.assets` for the user
🦋 Changeset detectedLatest commit: a68eb72 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
delucis
approved these changes
Jul 26, 2023
| @@ -89,6 +91,13 @@ class AstroBuilder { | |||
| command: 'build', | |||
| logging, | |||
| }); | |||
|
|
|||
| // HACK: Since we only inject the endpoint if `experimental.assets` is on and it's possible for an integration to | |||
There was a problem hiding this comment.
Is it worth a “Remove in 3.0” comment or would we pick it up anyway because experimental.assets will go away so this would be a type error?
There was a problem hiding this comment.
In 3.0 it's likely that we'll need an option to disable the endpoint (ex: maybe you have your own, maybe you don't want any assets stuff), so we'll still need to check for something in the config still here. So for now I'll leave it like this and update whenever we'll add that option
bluwy
approved these changes
Jul 27, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What the title says. We'd only check for
experimental.assetsbefore running the integration's config setup hooks, so we'd miss it if an integration would enable it for the user (such as StarlightTesting
Tested manually, we'll be removing this in 3.0 anyway, so
Docs
N/A