Match the .well-known directory when generating routes.json #7776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7be445a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
ematipico
approved these changes
Aug 17, 2023
ematipico
reviewed
Aug 17, 2023
ematipico
reviewed
Aug 17, 2023
bluwy
approved these changes
Aug 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This changeset causes the glob engine to match files in directories that start with a dot when generating a _routes.json file. This is necessary for matching files in a
.well-knowndirectory.Testing
When run with this change, the build process successfully generates an entry for "/.well-known/keybase.txt", which is otherwise excluded.
Docs
The docs currently state that all files in the
dist/folder will be listed in the_routes.jsonfile, and this change brings the code in line with the expected behavior listed in the documentation.