Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test in the Node adapter for astro:assets #7734

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

Princesseuh
Copy link
Member

Changes

What the title says. This PR also includes a very small fix where globalThis.astroAsset.addStaticImage could leak out of the program. This didn't affect normal usage, but was surfaced in the Node test.

Testing

It's tests!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

🦋 Changeset detected

Latest commit: a8b7ca0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Jul 20, 2023
@Princesseuh Princesseuh merged commit d5f526b into main Jul 26, 2023
@Princesseuh Princesseuh deleted the feat/node-adapter-image branch July 26, 2023 21:58
@astrobot-houston astrobot-houston mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants