Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for redirects config #7644

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Fixes for redirects config #7644

merged 3 commits into from
Jul 13, 2023

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Everything is tested.

Docs

N/A, bug fixes.

matthewp added 3 commits July 13, 2023 12:24
Got some great recommendations on how to handle our HTML written
redirect code based on SEO best practices.

See withastro/roadmap#466 (comment)

This implements them all.
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 16a5354

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 13, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

<meta name="robots" content="noindex">
<link rel="canonical" href="${location}">
<body>
<a href="${location}">Redirecting from <code>${fromPath}</code> to <code>${location}</code></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice touch!

@matthewp matthewp merged commit 213e109 into main Jul 13, 2023
@matthewp matthewp deleted the redirects-updates branch July 13, 2023 20:09
@astrobot-houston astrobot-houston mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
2 participants