Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@astrojs/cloudflare): SSR split file renaming misses ts endpoints #7568

Merged
merged 14 commits into from
Jul 17, 2023
Merged

fix(@astrojs/cloudflare): SSR split file renaming misses ts endpoints #7568

merged 14 commits into from
Jul 17, 2023

Conversation

alexanderniebuhr
Copy link
Member

Changes

  • fixed an bug, where ts endpoint files are not renamed to .js after bundle step

Testing

  • updated test suite
  • manually

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 79b2429

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 5, 2023
Copy link
Member Author

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some notes, for better understanding

packages/integrations/cloudflare/src/index.ts Outdated Show resolved Hide resolved
packages/integrations/cloudflare/src/server.directory.ts Outdated Show resolved Hide resolved
@alexanderniebuhr alexanderniebuhr changed the title fix(astrojs/cloudflare): SSR split file renaming misses ts endpoints fix(@astrojs/cloudflare): SSR split file renaming misses ts endpoints Jul 13, 2023
.changeset/large-meals-joke.md Outdated Show resolved Hide resolved
.changeset/sweet-bats-clap.md Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 6ec0407 into withastro:main Jul 17, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jul 17, 2023
@alexanderniebuhr alexanderniebuhr deleted the alexanderniebuhr/hotfix-cloudflare-ssr-split-endpoint branch September 23, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants