Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for examples check #7550

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Temporary fix for examples check #7550

merged 1 commit into from
Jul 3, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 3, 2023

Changes

The portfolio example is failing because of withastro/compiler#814

Not sure what's going on with a brief look, making a quick fix for now to have CI passing.

Testing

Ran pnpm test:check-examples locally.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2023

⚠️ No Changeset found

Latest commit: f1c146b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jul 3, 2023
@bluwy bluwy merged commit 0f0c31f into main Jul 3, 2023
@bluwy bluwy deleted the fix-example-check branch July 3, 2023 09:05
@natemoo-re natemoo-re mentioned this pull request Jul 5, 2023
Merged
matthewp pushed a commit that referenced this pull request Jul 11, 2023
@bluwy @matthewp
Temporary fix for examples check (#7550)
94ff55f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @ematipico