Fix astro:build:setup hook updateConfig utility
#7438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 177feb1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Jun 21, 2023
ematipico
reviewed
Jun 21, 2023
matthewp
approved these changes
Jun 21, 2023
Co-authored-by: Emanuele Stoppa <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While working on some fixes today, I noticed
astro:build:setuphook'supdateConfigutil doesn't actually update the config.In contrary, the
astro:config:setuphook'supdateConfigutil does actually update the astro config. So the above seems like a bug to me, which is fixed here.Testing
Added unit test.
Docs
Looks like it's not documented 🤔 https://docs.astro.build/en/reference/integrations-reference/#astrobuildsetup. The feature is added in #3392