Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update safe dependencies #7430

Merged
merged 11 commits into from
Jun 21, 2023
Merged

Update safe dependencies #7430

merged 11 commits into from
Jun 21, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 20, 2023 •
edited
Loading

Changes

Supersedes #7417

Update all non-major dependencies through pnpm update -r --interactive, except TypeScript, Zod, and Shiki, which were causing hard-to-fix TypeScript errors. And except @astrojs/compiler and @astrojs/language-server that are causing check error and slowness.

Some deps also caused TypeScript errors, but there are easily fixable, which is fixed in the 2nd commit.

There's more we can upgraded later which can be checked with pnpm outdated -r, but planning to tackle it separately.

Testing

Existing tests should pass. Also ran them locally.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c0d4005

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) feat: markdown Related to Markdown (scope) labels Jun 20, 2023
@bluwy bluwy mentioned this pull request Jun 20, 2023
Closed
1 task
natemoo-re
natemoo-re approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this one!

@natemoo-re natemoo-re mentioned this pull request Jun 20, 2023
Closed
@bluwy bluwy merged commit f275d05 into main Jun 21, 2023
@bluwy bluwy deleted the update-deps-safe branch June 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @ematipico @natemoo-re