-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up pnpm dev
#7424
Merged
Merged
Fix up pnpm dev
#7424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bce1418 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
reviewed
Jun 20, 2023
bluwy
approved these changes
Jun 20, 2023
matthewp
approved these changes
Jun 20, 2023
natemoo-re
approved these changes
Jun 20, 2023
github-actions
bot
added
the
pkg: astro
Related to the core `astro` package (scope)
label
Jun 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.d.ts
files in dev. Turns out, we had a bad glob where we clean up files. We needonlyFiles
to avoid deleting nested directories."persistent": true
with boosted concurrency per turborepo's recommendation.src/content/templates
to the project root. These were getting crawled bytsc
, which throws wacky build errors if you try to build twice!Testing
dev
runs and.d.ts
files are preserved"persistent": true
= faster dev perf needs extended testingDocs