Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update spread attribute #7310

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

Edo-San
Copy link
Contributor

@Edo-San Edo-San commented Jun 6, 2023

Changes

Add default value to spreadAttributes values argument, in order to prevent the function from throwing when spreading potentially undefined values.

This PR should fix issue #7222

Testing

No tests were added, as it is a fallback mechanism

Docs

No harmful changes in user behaviour 😉

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 7c6bc4f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 6, 2023
@natemoo-re natemoo-re linked an issue Jun 6, 2023 that may be closed by this pull request
1 task
@natemoo-re natemoo-re merged commit 52f0480 into withastro:main Jun 8, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spreading possibly undefined attributes on HTML element throws an Exception
2 participants