Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix injected scripts not injected to injected routes #7262

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Fix injected scripts not injected to injected routes #7262

merged 3 commits into from
Jun 6, 2023

Conversation

andremralves
Copy link
Contributor

@andremralves andremralves commented Jun 1, 2023 •
edited
Loading

Fixes #7203

  • Add new function to check if the file is an injected route.
  • Use this function in isPage() to consider injected Routes as pages.
  • This PR also fixes the styles injection.

Testing

  • Add a test case for the usage of injectScript with injectRoute.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f39a76f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 1, 2023
natemoo-re
natemoo-re approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for the fix!

@natemoo-re natemoo-re merged commit 144813f into withastro:main Jun 6, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 6, 2023
Merged
@delucis
Copy link
Member

delucis commented Jun 6, 2023

Thanks for fixing this @andremralves! Excited to see this in Astro v2.6!

@delucis delucis mentioned this pull request Jul 4, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injected scripts not injected to injected routes
3 participants
@andremralves @delucis @natemoo-re