Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content collection error message for empty folders #7118

Merged
merged 5 commits into from
May 19, 2023

Conversation

Princesseuh
Copy link
Member

Changes

This PR does two things:

  • Enhanced the error message to be more clear that it means there's no folder for a collection, and recommend the user to either create the folder or check their config
  • Fix empty folders not being added to the list of collections at start, they'll now be added the same way they would've had they'd been added post launch

Fix #6785

Testing

Tested manually

Docs

cc @withastro/maintainers-docs for feedback on the error message

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

🦋 Changeset detected

Latest commit: 68f1716

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 18, 2023
@bluwy
Copy link
Member

bluwy commented May 18, 2023

Looks like we also need a changeset (maybe after the test fix PR is merged)

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct-only you could be this thorough 👏

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct-only you could be this thorough 👏

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct-only you could be this thorough 👏

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

@Princesseuh Princesseuh merged commit 3257dd2 into main May 19, 2023
@Princesseuh Princesseuh deleted the fix/empty-collection-warning branch May 19, 2023 11:53
@astrobot-houston astrobot-houston mentioned this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor error message when collection doesn't have a folder / doesn't have entries
5 participants