Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <Code inline /> to output inline code #6959

Merged
merged 5 commits into from
May 3, 2023
Merged

Support <Code inline /> to output inline code #6959

merged 5 commits into from
May 3, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 2, 2023

Changes

Fix #5595

Support <Code inline /> to output inline code, which simply renders the inner code tag only, without the wrapper pre tag.

This PR refactors to use Shiki's renderToHtml API (as suggested at #5595 (comment)) to remove the repairShikiTheme hack.

Testing

Added a new test.

Docs

withastro/docs#3141

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: acc3dcd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You weren’t in-lying when you said this was great 👍

@matthewp matthewp merged commit cac4a32 into main May 3, 2023
@matthewp matthewp deleted the code-inline branch May 3, 2023 16:15
@astrobot-houston astrobot-houston mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Code> component is creating a bad HTML markup
3 participants