Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Sizes prop on Picture component #6773

Merged
merged 7 commits into from
Apr 10, 2023

Conversation

doganalper
Copy link
Contributor

@doganalper doganalper commented Apr 6, 2023

Changes

Set sizes prop as optional as it is not needed by default on
fixes #6125

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

🦋 Changeset detected

Latest commit: e6b08ad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 6, 2023
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@Princesseuh Princesseuh merged commit 99479e6 into withastro:main Apr 10, 2023
@astrobot-houston astrobot-houston mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@astrojs/image] sizes and background props should be optional on <Picture>
2 participants