Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdoc] Support automatic image optimization with experimental.assets #6630

Merged
merged 26 commits into from
Mar 24, 2023

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Mar 22, 2023

Changes

Testing

  • Add tests for absolute, relative, and aliased paths

Docs

Summarized in changeset. The experimental asset docs should cover expected behavior I think!

@bholmesdev bholmesdev requested a review from a team as a code owner March 22, 2023 20:52
@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

🦋 Changeset detected

Latest commit: 32ce2f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Mar 22, 2023
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. It looks really great!! I wish the Markdown version was this simple!

@bholmesdev bholmesdev merged commit cfcf2e2 into main Mar 24, 2023
@bholmesdev bholmesdev deleted the feat/markdoc-astor-image branch March 24, 2023 11:58
@astrobot-houston astrobot-houston mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants