Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdoc] Refactor Renderer internals to use renderComponent() #6607

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Update the Markdoc render internals to remove an unneeded dependency: stringify-attributes. Should also be more readable than the JSX implementation, using the same underlying methods as our compiler!

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: 68ae6bd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 20, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice refactor—much more readable!

@bholmesdev bholmesdev merged commit 86273b5 into main Mar 21, 2023
@bholmesdev bholmesdev deleted the refactor/new-markdoc-renderer branch March 21, 2023 12:17
@astrobot-houston astrobot-houston mentioned this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants