chore: wrap the projectDir in quotes if it contains spaces #6594
Conversation
🦋 Changeset detectedLatest commit: 8477bd8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
| if (projectDir.includes(' ')) { | ||
| projectDir = `"${projectDir}"`; | ||
| } | ||
| const enter = [ | ||
| `\n${prefix}Enter your project directory using`, | ||
| color.cyan(`cd ./${projectDir}`, ''), |
There was a problem hiding this comment.
This should use a real shell-quoting function like quote(["cd", `./${projectDir}`]) from the shell-quote library, rather than a one-off hack for just one of many shell metacharacters that might be misinterpreted.
There was a problem hiding this comment.
Since this only shows a hint of what to do next, and it's unlikely that someone would name their project with $ and ' etc, I think this is enough. It feels overkill to bring in a library for this.
Co-authored-by: Bjorn Lu <[email protected]>
|
@ematipico I added a screenshot #6594 (comment) |
* [ci] release * nit: typo in #6594 changeset --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Holmes <[email protected]>
Changes
When outputting projectDir in the terminal, if it contains spaces, wrap it in quotes.
Testing
Docs