Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It even starts to remove a file before it finish it. #6472

Merged
merged 7 commits into from
Mar 15, 2023

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Mar 9, 2023

Changes

fix: #6431

The fs.promises.rm even starts to execute when the copyFiles finish it.

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: 49c420e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 9, 2023
@JerryWu1234 JerryWu1234 changed the title dont finish the action of the copy before removing all files. It even starts to remove a file before it doesn't finish it. Mar 9, 2023
@JerryWu1234 JerryWu1234 changed the title It even starts to remove a file before it doesn't finish it. It even starts to remove a file before it finish it. Mar 10, 2023
@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 10, 2023 02:45
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the changeset to patch

@JerryWu1234
Copy link
Contributor Author

Please change the changeset to patch

cc @matthewp

@matthewp matthewp merged commit bf024cb into withastro:main Mar 15, 2023
@astrobot-houston astrobot-houston mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build process fails with file copy when outDir is in upper directory
4 participants