-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teardown compiler to improve rendering perf #6391
Conversation
🦋 Changeset detectedLatest commit: 6be32fd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!bench memory |
This comment was marked as outdated.
This comment was marked as outdated.
This is good for review now. The |
Hmm. This seems to make CI tests even longer! I guess it's a double-edge sword with the Maybe we can skip teardown for tests for now. |
!bench memory |
PR BenchmarkMemory
Main BenchmarkMemory
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to toggle the setting makes sense, still approved! 👍
Changes
Use
@astrojs/compiler
teardown()
API to remove the internal WASM instance and cache after we're finished with the Vite build.Testing
All existing test should pass.
!bench memory
should show an improvement too, but it doesn't because the technique to capture "heap used" includes the garbage collection root (for some reason).But when testing with docs locally, I can see the optimization working where Vite build memory gets offloaded during rendering.
Docs
n/a. internal refactor.