Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getSetCookie, if available #6347

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Use getSetCookie, if available #6347

merged 5 commits into from
Feb 23, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Feb 23, 2023

Changes

  • Related to fix(cookies): Update Undici to 5.20 and fix cookies behaviour #6323
  • Node 18's fetch implementation may have been updated to the broken version of undici, so we need to keep this manual workaround for now.
  • Once Node 18 is on [email protected]+ this should be fine to remove?
    • UPDATE: 18.14.1 is using the outdated version of undici, 18.14.2 is fine. We could wait for the CI images to update, but I think this is worth being defensive about.

Testing

Covered by existing tests

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

🦋 Changeset detected

Latest commit: ec9ccfb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 23, 2023
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 23, 2023
@natemoo-re natemoo-re merged commit 504c7ba into main Feb 23, 2023
@natemoo-re natemoo-re deleted the fix/get-set-cookie branch February 23, 2023 19:41
@astrobot-houston astrobot-houston mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants